Parskatt / DKM

[CVPR 2023] DKM: Dense Kernelized Feature Matching for Geometry Estimation
https://parskatt.github.io/DKM/
Other
385 stars 28 forks source link

Error when using option `do_pred_in_og_res=True` #2

Closed felipecadar closed 2 years ago

felipecadar commented 2 years ago

When using

dense_matches, dense_certainty = model.match(img1PIL, img2PIL, check_cycle_consistency=False, do_pred_in_og_res=True)

I got:

    738             if do_pred_in_og_res:  # Will assume that there is no batching going on.
    739                 og_query, og_support = self.og_transforms((im1, im2))
--> 740                 query_to_support, dense_certainty = self.matcher.upsample_preds(
    741                     query_to_support,
    742                     dense_certainty,

/opt/conda/lib/python3.7/site-packages/torch/nn/modules/module.py in __getattr__(self, name)
   1129                 return modules[name]
   1130         raise AttributeError("'{}' object has no attribute '{}'".format(
-> 1131             type(self).__name__, name))
   1132 
   1133     def __setattr__(self, name: str, value: Union[Tensor, 'Module']) -> None:

AttributeError: 'RegressionMatcher' object has no attribute 'matcher'

I belive you need to rename the variable self.matcher to self.decoder in line 740 of dkm.py (click here to see)

Parskatt commented 2 years ago

Woops, you're right.