Closed Vathys closed 1 year ago
Hi Vathys! Thanks for the contribution, I've not had time recently, but I'll have a look at your suggestion soon :)
Sorry, I'm a little new at this, and I have added some commits which I didn't mean to. I can try to cherry pick the commits to another branch and redo the pull request.
No worries :) Yes, probably having a specific branch is good.
Hello,
I am new to contributing on Github, so please excuse any mistakes I may have inadvertently made in the process.
While I was working with the model, I was having memory issues on my GPU while inferencing, so I thought to switch over to my CPU. While the matcher worked, the
sample
gave me an error. I noticed that thekde
function was detecting my GPU and automatically trying to use that instead of the CPU tensor which I had specified.To solve this issue, I added a
device
parameter to thesample
function which is then passed on tokde
. This may be a round about way of fixing this issue, but it worked for me. But I would be happy to come up with an alternative solution to this if you so feel.Thank you,
Vathys