Parsl / parsl

Parsl - a Python parallel scripting library
http://parsl-project.org
Apache License 2.0
497 stars 194 forks source link

work queue executor does not have type annotations #1694

Open btovar opened 4 years ago

btovar commented 4 years ago

Describe the bug work queue executor does not have type annotations. This means that it always passes make mypy when testing the code, even when incorrect types are used.

To Reproduce

  1. Checkout master branch commit 70d6f0f
  2. Confirm that parsl/executors/workqueue/executor.py does not have type annotations.

Expected behavior All functions and methods in the executor should have type annotations.

Environment

Distributed Environment It is independent of the distributed environment.

benclifford commented 4 years ago

cross-reference #873 which is about putting @typeguard.typechecked annotations on any function call that directly faces a user