search

Parsl / parsl

Parsl - a Python parallel scripting library
http://parsl-project.org
Apache License 2.0
484 stars 194 forks source link

MAINT: PEP-compliant code formatting #2046

Open vkhodygo opened 3 years ago

vkhodygo commented 3 years ago

Is your feature request related to a problem? Please describe. PyCharm throws tons of warnings but most of them seem to exist due to the code not being PEP-compliant. That is distracting and prevents from finding actual issues in the code.

Describe the solution you'd like Again, it is possible to reformat the files without breaking anything (manually or using an IDE). I can try and do this.

Describe alternatives you've considered I see none other than switching the warning off.

benclifford commented 3 years ago

In my opinion (which is not necessarily the opinion of other devs), either style should be enforced in CI (which it is with flake8 and perhaps to some extent mypy) or you should switch your dev environment to not be upset by parsl's CI-enforced style.

So to use a stricter style in general, I think it would be good to add enforcement of this into CI. Otherwise, that style is going to be violated after the next PR.

yadudoc commented 3 years ago

I care about having a consistent set of style guidelines and following it. We have a flake8 file here that is tested in CI. If you think any of the rules in there ought to be changed, that would be good to discuss. As Ben mentioned we also have mypy (partial support) which also has been useful.