Parsoa / SVDSS

Improved structural variant discovery in accurate long reads using sample-specific strings (SFS)
MIT License
42 stars 4 forks source link

About Extend Tier 2 #15

Closed songbowang125 closed 1 year ago

songbowang125 commented 1 year ago

Hi, I am reading your paper recently published online in Nature Methods. You provided a wonderful job on hard-to-call SV detection with a novel framework. However, I got some confusions about the Extend Tier 2 benchmarking.

  1. NIST_SVs_Integration_v0.6 FTP only provides a bed file for Tier 2 (HG002_SVs_Tier2_v0.6.bed). There is no Tier 2 VCF file so that Truvari is not applicable (You mentioned Truvari command in page xvi of supplementary file. Truvari requires both VCF file and included bed file). So you used another comparison tool (maybe bedtools intersection) for Tier 2?

  2. Could you please provide the details of Extend Tier 2? I didn't find the Extend Tier 2 file in your supplementary files and githubs. Extend Tier 2 played a key role in your benchmarking section and was much helpful for readers to run some tests or futher comparison.

Thanks

ldenti commented 1 year ago

Hi, thanks!

For extended tier 2, you are right, there is no .bed in the FTP server but we built it from Tier1 .bed using bedtools: extended Tier 2 is everything outside Tier 1, so we computed it by complementing the Tier1 .bed.

You can find all the steps to reproduce our exps here: https://github.com/ldenti/svdss-experiments:

Let me know if this helps you out.

Best,

ldenti commented 1 year ago

I tried to make it clearer in the README of that repo (here and here).

songbowang125 commented 1 year ago

oh, that really helps. I will do more tests. Thanks

ldenti commented 1 year ago

I'm closing this issue for now, if you have any other doubt/question on this, please reopen it.