Closed frank-f closed 5 months ago
Attention: Patch coverage is 62.06897%
with 11 lines
in your changes are missing coverage. Please review.
Project coverage is 61.67%. Comparing base (
9770ffa
) to head (2b80ec8
). Report is 2 commits behind head on master.:exclamation: Current head 2b80ec8 differs from pull request most recent head 6f295ce. Consider uploading reports for the commit 6f295ce to get more accurate results
Files | Patch % | Lines |
---|---|---|
.../Services/InfoProviderSystem/DTOs/ParameterDTO.php | 66.66% | 9 Missing :warning: |
...s/InfoProviderSystem/Providers/DigikeyProvider.php | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Got all tests to pass, so from my point of view my patch ready to be merged.
Let me know, if you'd like anything changed.
This seems like a good addition. I have added some tests for your code, so that changes dont break something unnoticed. Also fixed some edgecases.
Thank you
This will improve the following cases (example values):
-40°C ~ 125°C
This worked for LCSC only. Other providers needed "..." as range indicator and values with units could not be processed at all.
-40°C ~ 125°C @Tj
Extra info at the end stopped the range detection altogether, because the two "units" would not match. Extra info will now be saved to the "Text" column, making the units match and thus allowing the actual values to be saved as range.
22 µH
"µ" was missing in the unit detection regex