search

Part-DB / Part-DB-server

Part-DB is an Open source inventory management system for your electronic components
https://docs.part-db.de/
GNU Affero General Public License v3.0
782 stars 88 forks source link

added scan button and show/hide sidebar button to navbar #622

Closed RaptorDE closed 4 weeks ago

RaptorDE commented 1 month ago

This is a suggestion regarding the issues #620 und #621 . This is my first attempt at Symfony and Bootstrap. So I am not sure if I have chosen the right approach.

The ‘Show/Hide sidebar’ button certainly has room for improvement. Currently both buttons are available but not synchronised. I haven't fixed the problem with the visibility in dark mode either. Maybe the original button can also be removed? I have also not yet touched the function that changes the icon of the button. That's why the arrow is still the icon.

I don't expect my pull request to be accepted without changes.

This is how it looks: 2024-05-26 15_40_59-Part-DB – Mozilla Firefox

sidebar-ezgif com-optimize

jbtronics commented 1 month ago

I am not a fan of the sidebar collapse button in the navbar. I think it's too dominant there, and the function is more clear, when it is right next to the sidebar, like before.

I fixed the darkmode behavior of the sidebar collapse button, so that is not a problem anymore

RaptorDE commented 4 weeks ago

Thank you for the bugfix, I have moved the scan button in the mobile view to a new pull request. #626