search

Parth-Vader / YoutubeDataCollector

4 stars 4 forks source link

Added the Youtube Icon, CSS and Hyperlink. #14

Closed yashrsharma44 closed 6 years ago

yashrsharma44 commented 6 years ago

I have made a new PR after rectifying my mistakes in the earlier PR. Please consider that.

Parth-Vader commented 6 years ago

Looks good to me, was the pop up box intended when clicked on "Click to Open"?

yashrsharma44 commented 6 years ago

Sorry, it was some sloppy work from me. I wanted to add the pop up when a bookmark is added, but added for the button, "Click to Open". Correcting it.

Parth-Vader commented 6 years ago

@yashrsharma44 It's alright - checking it again, but always test and try before adding a commit and sending a PR - and mention features added and bugs that remain.

yashrsharma44 commented 6 years ago

Thanks. However, there is a bug that I wanted to discuss. While extracting the title from the history, if I am viewing the video for the first time, the title is visible. However, when I replay the video, and try to save the bookmark, then the title is replaced by Youtube. So any ideas how to deal with that?

Parth-Vader commented 6 years ago

@yashrsharma44 Lets discuss in the slack group.