search

Parth-Vader / YoutubeDataCollector

4 stars 4 forks source link

Add a suitable favicon #6

Closed Parth-Vader closed 6 years ago

Parth-Vader commented 6 years ago

Could be anything related to youtube + history.

mritunjayz commented 6 years ago

128p would it be better?

Parth-Vader commented 6 years ago

@mritunjaygoutam12 The watermark doesn't look great.

vchrombie commented 6 years ago

How about this icon? logo

Parth-Vader commented 6 years ago

@vchrombie It should be related to history, youtube or something like that. This doesn't fit the description.

vchrombie commented 6 years ago

How about this?

logo

I replaced the play symbol with the history symbol.

Parth-Vader commented 6 years ago

@vchrombie This looks perfect for the job. :+1:

vchrombie commented 6 years ago

Thanks! Can I send a PR for this?

Parth-Vader commented 6 years ago

You never ask if you can send a PR if your idea is approved. You do it. ;)

vchrombie commented 6 years ago

Thank You!

vchrombie commented 6 years ago

How to integrate the logo?

<link rel="icon" type="image/x-icon" href="#"> in the history.html

Is it correct? I am not able to do that.

Parth-Vader commented 6 years ago

@vchrombie Look at this answer. Also, ask your doubts in the slack channel instead.

vchrombie commented 6 years ago

I think this issue is solved now #9.