ParthGandhiNUS / pe

0 stars 0 forks source link

Wrong error message for using string for buy #5

Open ParthGandhiNUS opened 6 months ago

ParthGandhiNUS commented 6 months ago

Not specified anywhere that buy must be an int, float, or double. No documentation proper documentation found in the UG for what type the "buy" should be.

image.png

nus-pe-bot commented 6 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Wrong error message for using float/double for qty

The error shown does not specify the user that float/double is not allowed for quantity. Misleading because the format is correct. Not mentioned in UG that double/float values cant be used for quantity.

image.png


[original: nus-cs2113-AY2324S2/pe-interim#385] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Noted that qty being an integer should be included in the UG so that new users are not confused

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** As a user, I would like to know what is the error I am making. I believe as the developer of an application for keeping track of inventory the user should know exactly why and where he/she is going wrong.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/ParthGandhiNUS/pe/main/files/a7923446-8d4b-419c-ab04-6c1645bb7fc8.png) Definitely cannot be considered as an cosmetic issue. Group need to use more appropriate error/exception messages instead of reusing one which does not even fit the context.