ParthJadhav / Rust_Search

Blazingly fast file search library built in Rust
MIT License
140 stars 15 forks source link

feat: add flag to exclude directories from filtering #35

Open dolsem opened 11 months ago

dolsem commented 11 months ago

Currently if you apply filters to search it will ignore everything inside a directory that does not match a filter. So if you, for example. want to recursively find all files in the tree that have been modified today, it won't work. This is expect behavior of filter_entry(), see here.

This PR adds a flag to prevent applying filters to directories and only look at the files.

edwardgra4ev commented 11 months ago

@dolsem I decided to try Tauri, found this repository to implement the necessary functionality. I was very upset when I found this non-intuitive behavior. I'm waiting for your correction to be added

dolsem commented 10 months ago

I updated the PR renaming the flag to just dirs and removing directory entries from results when set to false. I think this makes more sense.

dolsem commented 10 months ago

I'd love to get feedback on the PR, if there is interest in merging it, I can update document this feature in the README as well.

edwardgra4ev commented 10 months ago

@dolsem There is a lot of interest. I am currently studying rust and tauri on my project using "Rust search" and your changes have helped me a lot in the project. Now in my project, "rust search" is taken from your fork

dolsem commented 10 months ago

@edwardgra4ev thank you, that's good to know. Hopefully there will be interest from maintainers as well, so that the PR can get merged.

ParthJadhav commented 10 months ago

Hey guys, I created this repository solely to work as a search library for Verve. I'm working on other stuff currently and don't get much time to work on my open-source projects.

I'll merge these changes. Thanks for the contribution @dolsem and sorry for the delay @edwardgra4ev .

ParthJadhav commented 10 months ago

Hey @dolsem , the builds are failing. Can you have a look?

dolsem commented 10 months ago

@ParthJadhav I'll update it today.

dolsem commented 10 months ago

@ParthJadhav I fixed all the broken tests

dolsem commented 10 months ago

@ParthJadhav any update?