search

ParthJadhav / Tkinter-Designer

An easy and fast way to create a Python GUI 🐍
BSD 3-Clause "New" or "Revised" License
8.96k stars 821 forks source link

Change Button to Label #196

Closed omar2205 closed 2 years ago

omar2205 commented 2 years ago

@ParthJadhav

ParthJadhav commented 2 years ago

Hey @omar2205 Thanks for the PR. I'll be reviewing the changes soon and will get back to you. Sorry for the delay.

ParthJadhav commented 2 years ago

Hey @omar2205 , I tested this and didn't find satisfying results :-

image

ParthJadhav commented 2 years ago

Here's the test file.

https://www.figma.com/file/WVLnulVsI177tvnxSdqOUZ/Example-File?node-id=913%3A2

omar2205 commented 2 years ago

Try this one. I must have forgotten to push this.

Check this repo: https://github.com/omar2205/imgs-lottie

ParthJadhav commented 2 years ago

I'll test this commit. Thanks !

ParthJadhav commented 2 years ago 
  File "C:\Users\Admin\development\Tkinter-Designer\build\gui.py", line 130, in <module>
    button_1 = Label(
NameError: name 'Label' is not defined

I also realized that even if it improved the result. That's not the right thing to do. because most of the users would want it to be Button and not a label. It would create confusion.

ParthJadhav commented 2 years ago

Unfortunately, I won't be able to merge this PR. Thanks for taking the efforts @omar2205 .

omar2205 commented 2 years ago

My point was, buttons have active state that is hard to get rid off. And they look ugly. In Figma you would call it a button but under the hood it will be a label.

Anyways, do what you want. When I use this to generate GUIs, I will change every Button to a Label.