fix: shortcuts with `Option` key

[Ty3uK]

Related to #11.

event.key returns transformed char when option key is pressed.

For example, when user is trying to record shortcut Option+Shift+G, event.key returns Option+Shift+˝.

event.code returns KeyG instead. So getting substring with offset 3 fixes this issue.

This commit fixes another bug: when user records shortcut that already registered, window will hide. Adding unregister before start recording fixes this issue.

[ParthJadhav]

Ohh, I see. That's alright. We will resolve it in different PR. This doesn't seem to be that important as of now

[ParthJadhav]

Do you think this PR is ready to merge?

[Ty3uK]

Do you think this PR is ready to merge?

Give me another five minutes to check production release 🫡

[Ty3uK]

Got another bug when trying to set Option+Shift+Space shortcut

[Ty3uK]

Also, quick question: do I need to squash commits or you prefer to preserve full history of changes?

[ParthJadhav]

Also, quick question: do I need to squash commits or you prefer to preserve full history of changes?

Oh dw, I'll directly do Squash & Merge

[ParthJadhav]

TBH, The whole shortcut recorder function is messy & hard to understand.

[Ty3uK]

TBH, The whole shortcut recorder function is messy & hard to understand.

You can create issue and assign it to me, if you want. I can do some refactoring 🙂

[ParthJadhav]

I've tested it and everything works as expected... Except if anything else launches while setting the shortcut then we can only open the window by clicking the menu item

[Ty3uK]

I've tested it and everything works as expected... Except if anything else launches while setting the shortcut then we can only open the window by clicking the menu item

Maybe we can do some researching for global shortcuts from Rust itself? I think Tauri do this under the hood, but maybe some other library can do this better...

[ParthJadhav]

I've tested it and everything works as expected... Except if anything else launches while setting the shortcut then we can only open the window by clicking the menu item

Maybe we can do some researching for global shortcuts from Rust itself? I think Tauri do this under the hood, but maybe some other library can do this better...

Oh no, Everything works as expected. But the fact that we unregister the key before recording the shortcut is causing the problem.

What do you think?

[ParthJadhav]

You can create issue and assign it to me, if you want. I can do some refactoring 🙂

I think we can do it at later time when we find to be working on any issue related to the shortcut function... What are you opinion on it?

[Ty3uK]

I've tested it and everything works as expected... Except if anything else launches while setting the shortcut then we can only open the window by clicking the menu item

Maybe we can do some researching for global shortcuts from Rust itself? I think Tauri do this under the hood, but maybe some other library can do this better...

Oh no, Everything works as expected. But the fact that we unregister the key before recording the shortcut is causing the problem.

What do you think?

I've tried to comment unregister and it does nothing 🥲

[Ty3uK]

You can create issue and assign it to me, if you want. I can do some refactoring 🙂

I think we can do it at later time when we find to be working on any issue related to the shortcut function... What are you opinion on it?

Great catch! I think the same way 🙂

[ParthJadhav]

I've tested it and everything works as expected... Except if anything else launches while setting the shortcut then we can only open the window by clicking the menu item

Maybe we can do some researching for global shortcuts from Rust itself? I think Tauri do this under the hood, but maybe some other library can do this better...

Oh no, Everything works as expected. But the fact that we unregister the key before recording the shortcut is causing the problem. What do you think?

I've tried to comment unregister and it does nothing 🥲

If you just unbind the unregister line you would notice that the pre-existing shortcut still works after you try to set a shortcut which already exist.

Eg: if you try option + command + space without unregister then it would now listen for the default shortcut which was CMD + SHIFT + G... But with Unregister it wouldn't listen for anything..

[ParthJadhav]

Do you use Discord by any chance ? It would be easier to communicate there IMO 😄

[Ty3uK]

Do you use Discord by any chance ? It would be easier to communicate there IMO 😄

Yes 🙂 Ty3uK#0057

[Ty3uK]

I've tested it and everything works as expected... Except if anything else launches while setting the shortcut then we can only open the window by clicking the menu item

Maybe we can do some researching for global shortcuts from Rust itself? I think Tauri do this under the hood, but maybe some other library can do this better...

Oh no, Everything works as expected. But the fact that we unregister the key before recording the shortcut is causing the problem. What do you think?

I've tried to comment unregister and it does nothing 🥲

If you just unbind the unregister line you would notice that the pre-existing shortcut still works after you try to set a shortcut which already exist.

Eg: if you try option + command + space without unregister then it would now listen for the default shortcut which was CMD + SHIFT + G... But with Unregister it wouldn't listen for anything..

Got it. So maybe I just drop this line and we put this in another issue?

Also, we can do some refactoring just for resolving that kind of issues 🙂

[ParthJadhav]

I've tested it and everything works as expected... Except if anything else launches while setting the shortcut then we can only open the window by clicking the menu item

Maybe we can do some researching for global shortcuts from Rust itself? I think Tauri do this under the hood, but maybe some other library can do this better...

Oh no, Everything works as expected. But the fact that we unregister the key before recording the shortcut is causing the problem. What do you think?

I've tried to comment unregister and it does nothing 🥲

If you just unbind the unregister line you would notice that the pre-existing shortcut still works after you try to set a shortcut which already exist. Eg: if you try option + command + space without unregister then it would now listen for the default shortcut which was CMD + SHIFT + G... But with Unregister it wouldn't listen for anything..

Got it. So maybe I just drop this line and we put this in another issue?

Also, we can do some refactoring just for resolving that kind of issues 🙂

Yep, lets do that 🙌

[ParthJadhav]

Awesome, Let's merge it 🚀