search

ParthJadhav / Verve

Verve is a lightweight and blazingly fast launcher for accessing and opening applications, files and documents. ⚡
GNU Affero General Public License v3.0
658 stars 25 forks source link

feat: show window on full screen apps #39

Open ParthJadhav opened 1 year ago

ParthJadhav commented 1 year ago

closes: #36

ParthJadhav commented 1 year ago

Hey @benediktms , The above changes seem to work on Dev environment but doesn't work on release builds. Can you test ?

benediktms commented 1 year ago

@ParthJadhav sure I'll have a look

benediktms commented 1 year ago

Could you tell me what the requirements are to compile for release (I already installed create-dmg)? The package.json script fails: Screenshot 2023-01-14 at 10 32 06

When I tested it locally it also worked fine. Does cacao require use to use unsafe rust code in order to work?

ParthJadhav commented 1 year ago

I think its compiled properly, trying Checking the path it gave above.

ParthJadhav commented 1 year ago

Also instead of running package-and-build try running yarn tauri build this will generate an .app file and not a dmg

benediktms commented 1 year ago

My bad I actually had the wrong create-dmg installed it works now, but I am getting the same results, release is not handling this correctly... But I'm not sure what the cause could be...

ParthJadhav commented 1 year ago

Hmm, I tried different approaches from different projects but none of them seems to work 🥲

https://github.com/ahkohd/tauri-macos-spotlight-example https://github.com/BiliGoldenWater/ChaosDanmuTool/blob/dev/src-tauri/src/utils/window_utils.rs https://github.com/tauri-apps/tao/commit/0aa2176c31fbc76cdc7746601c9bc3d0da449a88

benediktms commented 1 year ago

Seems like this is a discussion in the tauri community: https://github.com/tauri-apps/tauri/issues/2801

ParthJadhav commented 1 year ago

https://github.com/ahkohd/tauri-macos-spotlight-example

Yep, Already read all of them. But one thing stands out is that: https://github.com/ahkohd/tauri-macos-spotlight-example

This app manages to do everything flawlessly :) I copied over everything and it still doesn't seem to work. Can u try it maybe?

benediktms commented 1 year ago

This repo seems to be using objective-c binding to help manage the window placement? Have you tried that?

ParthJadhav commented 1 year ago

Yep, I literally copied over everything as it was. Didn't work :(

benediktms commented 1 year ago

Well we can always wait until tauri adds their own implementation I guess...

ParthJadhav commented 1 year ago

Well we can always wait until tauri adds their own implementation I guess...

Let's do that. I'll put this PR in draft.