Closed Langlais115 closed 6 years ago
For the include_once / require_once
Thanks, but, I don't have to do it on all files, because some files are outside librairies, so don't tweak them.
The correction to ['modules']['authenticator'] seems legit. But I started a check on the install process and normally (but who knows) it won't happen in a near future. I take it.
So for the moment, I can't merge this PR.
Fair enough. Thanks for your explanations.
PR the module thing separetely I will surely take it. For the include_onces, with distinction, same thing.
So try it again, pleeeeeeeeeeeease
Hi,
May I propose to change all the include_once into require_once? (as if a file is not found it should raise an error and stop. Using include, the application is trying to go further and might become unstable.)
I also remove all the @ sign in front of the require_once as it hide error. Errors should NEVER be hidden but handled.
And finally I add a check in the connect.php file (line 94) as the variable is not set by default.