search

PartialityModding / PartialityLauncher

The launcher for Partiality.
MIT License
26 stars 17 forks source link

Log file never gets written if window doesn't open #1

Open Benjamin-L opened 6 years ago

Benjamin-L commented 6 years ago

The issue is this section of code. When GameManager.SaveAllMetadata() is called, it assumes that exePath has been set, which isn't the case if the try-catch block stops things early. At this point it tries to dereference the null and the whole thing crashes. Unfortunately, this stops the program before it ever writes the log file. This is really unfortunate in cases where the actual error is really simple, such as my case where it was a missing font.

I don't really know any C#, and also can't compile this on my computer anyway, which is why I didn't make a pull request, but this should be pretty simple to fix, I think.

ZandrXandr commented 6 years ago

While this is true, -quicklaunch is made with the intention of already having everything set up, and just needing a... quicker way to launch. Quicklaunch mode has no way to select a game.

1.0.0 will fix this, though, thanks for reporting.