ParticleCore / Iridium

Iridium is an extension built to improve your YouTube experience
Other
1.32k stars 138 forks source link

Video modifications might not apply when video reloads after being paused for too long #916

Closed ParticleCore closed 10 months ago

ParticleCore commented 10 months ago

Video player might be loading an unchanged configuration (for example, if ads are not enabled they will still show) after resuming a video that was paused for too long causing the current data to expire, and a new one to be loaded.

Need to investigate how that new data is being loaded as to implement the configuration changes as well.

ParticleCore commented 10 months ago

Seems like the video data does not change as I initially thought when the video info expires, it simply loads new data. However, if the ad information is still in memory then YT will prioritize that during the refresh request and load an ad instead.

The extension did not override original data when changing player args to make it simpler to show monetization info, but as a result of this issue that is no longer possible to keep.

The solution was to simply erase the ad information in the original data source and seems to be working now.