search

ParticleCore / Iridium

Iridium is an extension built to improve your YouTube experience
Other
1.32k stars 138 forks source link

Fix issues with recent refactor causing short control feature to not work #927

Closed ParticleCore closed 9 months ago

ParticleCore commented 9 months ago

App has been recently refactored so it is more structured and modular.

However, as a result some parts of the core code are no longer working as they were before due to how arrow functions work in regards to arguments.

For example,

https://github.com/ParticleCore/Iridium/blob/4f1470938d87defe8144710e3e94c414ba48eb57/src/chrome/js/background-inject.js#L1285-L1292

or

https://github.com/ParticleCore/Iridium/blob/4f1470938d87defe8144710e3e94c414ba48eb57/src/chrome/js/background-inject.js#L1324-L1329

The arguments here does not reflect the data passed to the scoped function and as a result it will not process the respective data.

So far it appears to be only affecting the ability to disable shorts so other features are not affected by this as far as I could tell.

Currently this only affects the Chrome extension since that one was recently shipped with this refactor, but it will be affecting the Firefox version as well if it is not addressed in the next version.