search

ParticleCore / Iridium

Iridium is an extension built to improve your YouTube experience
Other
1.31k stars 139 forks source link

Always visible feature not working correctly with new video page UI #951

Closed ParticleCore closed 4 months ago

ParticleCore commented 4 months ago

The new video page UI has some changed elements that are causing the feature to malfunction, even if it is turned off.

Seems like some crucial elements are missing from the page which the feature relies on to work properly.

ParticleCore commented 4 months ago

Two checks were not including the setting state before making changes, this then allowed the chain of events to skip crucial steps and make changes:

https://github.com/ParticleCore/Iridium/blob/e135560d1ecd842d1398abbd0d1815a13b0357d1/src/firefox/js/background-inject.js#L936

https://github.com/ParticleCore/Iridium/blob/e135560d1ecd842d1398abbd0d1815a13b0357d1/src/firefox/js/background-inject.js#L806