ParticleCore / Iridium

Iridium is an extension built to improve your YouTube experience
Other
1.31k stars 139 forks source link

Fix videos not playing with shortcuts when autoplay is disabled #963

Closed ParticleCore closed 3 months ago

ParticleCore commented 3 months ago

The new autoplay method has been working well, but seems like it is not accounting for play requests from other sources that are not a mouse click (spacebar, letter K, media playback buttons).

Will have to add these to the exclusion list since these are intentional user actions, as long as they aren't being entered in a text area (search, comments, chat, etc.). There should be a shortcut handler to make this easier.

ParticleCore commented 3 months ago

The feature should now be able to correlate autoplay requests where the last key pressed is either k or spacebar, and resets it promptly and also resets it when the page is clicked.

The media playback shortcuts do not appear to be dependent on page content, they act directly in the player and that bypasses any playback control already. It is also not capable of playing a video that has not yet played, and seems like this is by design.