search

ParticleCore / Particle

Home of the extension YouTube Plus that allows you to experience more on YouTube
Other
1.06k stars 228 forks source link

Reopening #221 #222

Closed keLston closed 8 years ago

keLston commented 8 years ago

As per your instructions, as i've noted in the now closed #221 I reset my profile and thereby the modified settings to default.

The result, unfortunately, is that the problem was still replicated.

But now, annoyingly, i'm horribly inconvenienced having to restore all my previous saved web settings without a solution to the previously mild inconvenience and having my issue flagged invalid.

JourneyOver commented 8 years ago

Have the same problem as issued in #221 but its happening in chrome for me, video player seems to only have a pause button on it and the timer is stuck on -NaN:NaN..

Have disabled all scripts/extensions and tried resetting my profile as well, in the end even with just this script enabled it still seems to bring about this problem, whenever I have it disabled the youtube video controls come up as expected.

Edit: so after messing around a bit some more, the problem does seem to be coming from this as when clearing my total history and going to a youtube video all the normal things but if I refresh the page or go to another video the problem comes back once again with it just showing the pause button. Dunno what else could be causing this tbh and I tried the script on firefox to see if I could replicate it there but it worked just as expected on there so I dunno what else could be the cause of all this...

pep0w commented 8 years ago

I have just started forefox (after quite some time), and I have the problem with only pause button there, everything else is missing. Not even the 'shortcuts always active is working. But when disabling the script it's fine.

ParticleCore commented 8 years ago

When the issue occurs press Ctrl + Shift + J to open the console and see if there are any warnings and/or errors showing up, paste them here in full.

@keLston You said that when you created a new profile you were not able to replicate the problem which was a confirmation that the issue was not related to YT+ and thus flagged as invalid. If I cannot replicate it or understand what is causing it then I am not able to fix it, which is why the troubleshooting guide exists to facilitate debugging.

All the rest please follow the troubleshooting guide to the end: https://github.com/ParticleCore/Particle/wiki/Report-a-problem

I also need more information that you can provide, as indicated in the previous link, such as Operating system, YT+ version, browser name and version, etc.

JourneyOver commented 8 years ago

With only particle(youtube+) or tampermonkey and the userscript enabled this is the only error that I seem to get in the console that doesn't appear when either of the two are disabled -

Uncaught URIError: URI malformedya @ base.js:14ej @ base.js:274ax @ base.js:846Tw @ base.js:857Uw @ base.js:843Sx @ base.js:897C7 @ base.js:2918f.Bg @ base.js:5754f.S @ base.js:3164f.S @ base.js:4319f.Zm @ base.js:5916f.S @ base.js:3164Jj.S @ base.js:3254uL @ base.js:1531f.pE @ base.js:4178(anonymous function) @ VM2012:1168fd @ base.js:85f.Z @ base.js:3117f.eG @ base.js:4030

That is it in full of what appears as I can't make it open up anymore than that.

Anyways below is all the other info I can provide -

Browser Name: Chrome

Browser Version: 48.0.2564.109

Operating System: Windows 10 64bit

Software Type: Tried both extension version and script version resulting same problem both times

Software Version: 1.1.5

Userscript Manager: Tampermonkey

Userscript Version: Beta 4.0.5070

Problem Description: With script or the extension enabled videos only have the play/pause button and the top info bar, the timer is stuck on -NaN:NaN. As shown here -> http://files.catbox.moe/02u5vs.png

Steps to reproduce: Enable script or extension and go to a youtube video.

ParticleCore commented 8 years ago

@JourneyOver Thanks for this, it is exactly the same problem that is happening with @keLston and I assume @q1k as well, so it is too much of a coincidence to rule this on a common factor that you could be sharing, I will try to find out what is causing it. Problem is, I have been trying with 3 different browsers and 2 systems since yesterday, but I am not having any luck so far, which is why any information you can provide is always helpful.

ParticleCore commented 8 years ago

@JourneyOver This might be caused by a new YouTube source code that I have not yet received (they often do A|B testing), so could you please go to any YouTube video, open the console again (Ctrl + Shift + J) and enter the following:

ytplayer.config.assets.js

Copy here the link that it shows, for example //s.ytimg.com/yts/jsbin/player-en_US-vfl329t6E/base.js

Then enter the following:

document.querySelector("[src*='base.js']").src

Copy here the link that it shows, for example https://s.ytimg.com/yts/jsbin/www-en_US-vflYaEVNh/base.js

This way I will be able to see exactly what might be happening with the correct source codes.

JourneyOver commented 8 years ago

@ParticleCore this is the link it shows from the first command - "//s.ytimg.com/yts/jsbin/player-en_US-vfl329t6E/base.js"

this is the link it shows from teh second command - "https://s.ytimg.com/yts/jsbin/player-en_US-vfl329t6E/base.js"

seems the first link is an exact copy of yours but the second one is different.

JourneyOver commented 8 years ago

@ParticleCore if you need anything else let me know, as I'll be sitting here watching this for a bit.

ParticleCore commented 8 years ago

@JourneyOver The second link is not the one I was after, try the following command instead

document.querySelectorAll("[src*='base.js']")[1].src

JourneyOver commented 8 years ago

@ParticleCore

here ya go - "https://s.ytimg.com/yts/jsbin/www-en_US-vflYaEVNh/base.js"

JourneyOver commented 8 years ago

@ParticleCore it looks like it gave the same link as what you had as well above for the second link.. Have a feeling you're so lost on what could be causing this issue..

ParticleCore commented 8 years ago

That's correct, one less thing to worry about, now I know we both have the same source codes so it will be easier for me to test more things.

If you don't mind, when the problem happens open the console again and enter the following:

JSON.stringify(ytplayer.config.args)

It will return a large block of code, before copying the text make sure you expand the rest that is hidden by going to the end of the text and click on the [...] button, after that you can copy it all and paste here.

Additionally share the YT+ settings you have. I doubt they will make a difference since you already tried with the settings reset to default, but it is always good to try it nonetheless.

JourneyOver commented 8 years ago

@ParticleCore Here is the whole thing that it returned, there was no [...] at the end of it so I think chrome just showed it all to begin with for me xD

ParticleCore commented 8 years ago

Thank you, I removed it because it could contain personal information. I will now try to see this further, but it can take some time. If I need more information I'll let you know, thanks for all the help so far.

JourneyOver commented 8 years ago

Its not a problem at all glad to be of help when I can, love this script and hate browsing youtube without it.

JourneyOver commented 8 years ago

@ParticleCore before I forget here is my YT+ settings as well if you want to take a look at them.

{
  "GEN_BTTR_NTF": true,
  "GEN_SUB_LIST": true,
  "GEN_INF_SCRL": true,
  "GEN_BLUE_GLOW": true,
  "GEN_PPOT_ON": true,
  "VID_END_SHRE": true,
  "VID_DFLT_QLTY": "hd1080",
  "VID_PLST_ATPL": true,
  "VID_PLST_RVRS": true,
  "VID_PLR_ALVIS": true,
  "VID_PLR_SIZE_MEM": true,
  "VID_PLR_FIT": true,
  "VID_HIDE_COMS": "0",
  "VID_POST_TIME": true,
  "VID_VID_CNT": true,
  "VID_DESC_SHRT": true,
  "VID_PPOT_SZ": false,
  "VID_PLR_HTML5": true,
  "BLK_ON": true,
  "floaterX": 0,
  "floaterY": 0,
  "firstTime": false,
  "volLev": 50,
  "advOpts": false,
  "blacklist": {},
  "extLang": {},
  "GEN_HDE_CHN_SDBR": false,
  "GEN_HDE_SRCH_SDBR": true,
  "GEN_HDE_RECM_SDBR": true,
  "GEN_HIDE_FTR": true,
  "GEN_CMPT_TTLS": false,
  "GEN_DSB_HVRC": false,
  "GEN_GRID_SRCH": true,
  "GEN_GRID_SUBS": true,
  "GEN_CHN_DFLT_PAGE": "default",
  "GEN_SPF_OFF": false,
  "GEN_REM_APUN": true,
  "GEN_YT_LOGO_LINK": true,
  "GEN_DSBL_ADS": true,
  "GEN_LOCL_LANG": true,
  "VID_LAYT_AUTO_PNL": false,
  "VID_HIDE_DETLS": false,
  "VID_TTL_CMPT": false,
  "VID_PLR_FIT_WDTH": "1645",
  "VID_PLR_DYN_SIZE": false,
  "VID_PLR_INFO": false,
  "VID_PLR_HFR": false,
  "VID_PLR_DASH": false,
  "VID_VOL_WHEEL": true,
  "VID_PLR_ALACT": false,
  "VID_PLR_VOL_MEM": true,
  "VID_PLR_ANTS": false,
  "VID_PLR_CC": false,
  "VID_PLR_ATPL": true,
  "VID_PLR_ALVIS_WDTH": false,
  "VID_SUB_ADS": false,
  "VID_PLR_ADS": true,
  "theaterMode": true
}

and it seems that with this issue going on the Fit to page in theater mode and Fit to page max width:doesn't work at all.

ParticleCore commented 8 years ago

I think I made progress but I need to confirm it further since I am not able to reproduce it on my side by default. Could you open the same video that is affected by this problem with YT+ disabled and type in the console the following:

ytplayer.config.args.rvs

Copy the text it shows so that I can analyze it.

JourneyOver commented 8 years ago

@ParticleCore every video on youtube is affected by the problem whenever it's enabled (as soon as YT+ is disabled the video player works as expected though), it's not just a few here and there.

but here is the text it shows for a video while YT+ is disabled.

"author=GameGrumps&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2Fqx8IP4u2BOY%2Fhqdefault.webp&endscreen_autoplay_session_data=autonav%3D1%26itct%3D%2508%2516%2510%25E1%2592%2501%2522%2513%2508%25D6%2594%25D5%2582%25C3%25FF%25CA%2502%2515%25CCoN%250A%251D8%25DB%250Ex%2528%25F8%251D2%250Crelated-auto%26playnext%3D1&short_view_count_text=&title=Animal+Crossing+Amiibo+Festival%3A+Finale+-+PART+6+-+Grumpcade+%28Ft.+SoloTravelBlog&id=qx8IP4u2BOY&session_data=itct%3DCBUQvU4iEwjWlNWCw__KAhXMb04KHTjbDngo-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&length_seconds=1236&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2Fqx8IP4u2BOY%2Fmqdefault.webp,author=Tal+Rimoni&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FG5VFwC2uH2Y%2Fhqdefault.webp&short_view_count_text=&title=Game+Grumps+Link+to+the+Past+Best+Moments&id=G5VFwC2uH2Y&session_data=itct%3DCBQQvU4iEwjWlNWCw__KAhXMb04KHTjbDngo-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&length_seconds=3632&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FG5VFwC2uH2Y%2Fmqdefault.webp,author=Tal+Rimoni&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FWaAjbeGgGi0%2Fhqdefault.webp&short_view_count_text=&title=Game+Grumps+Legend+of+Zelda+Best+Moments&id=WaAjbeGgGi0&session_data=itct%3DCBMQvU4iEwjWlNWCw__KAhXMb04KHTjbDngo-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&length_seconds=3265&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FWaAjbeGgGi0%2Fmqdefault.webp,author=Penguin+Pandas&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FQTSkIGajFz4%2Fhqdefault.webp&short_view_count_text=&title=The+Co-Optional+Star+Destroyer&id=QTSkIGajFz4&session_data=itct%3DCBIQvU4iEwjWlNWCw__KAhXMb04KHTjbDngo-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&length_seconds=395&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FQTSkIGajFz4%2Fmqdefault.webp,author=Tal+Rimoni&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FQVU-0ajMkWs%2Fhqdefault.webp&short_view_count_text=&title=Game+Grumps+Dog+Island+Best+Moments&id=QVU-0ajMkWs&session_data=itct%3DCBEQvU4iEwjWlNWCw__KAhXMb04KHTjbDngo-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&length_seconds=2103&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FQVU-0ajMkWs%2Fmqdefault.webp,author=Game+Grumps+%C2%A9&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FtSpt6byu7o4%2Fhqdefault.webp&short_view_count_text=&title=Game+Grumps+%E2%84%A2+-+Shovel+Knight+Co-Op%3A+Winner%26%2339%3Bs+Mountain+-+PART+16+-+Game+Grumps+%E2%84%A2&id=tSpt6byu7o4&session_data=itct%3DCBAQvU4iEwjWlNWCw__KAhXMb04KHTjbDngo-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&length_seconds=676&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FtSpt6byu7o4%2Fmqdefault.webp,author=PlasmaBoom&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FhW7BqaxP5-g%2Fhqdefault.webp&short_view_count_text=&title=Condensed+Game+Grumps+-+Castlevania+2%3A+Simon%27s+Quest+Compilation&id=hW7BqaxP5-g&session_data=itct%3DCA8QvU4iEwjWlNWCw__KAhXMb04KHTjbDngo-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&length_seconds=1898&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FhW7BqaxP5-g%2Fmqdefault.webp,author=BestOf+LetsPlay&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FLqZKIDnRO9Q%2Fhqdefault.webp&short_view_count_text=&title=The+Best+of+Game+Grumps+-+Super+Mario+64&id=LqZKIDnRO9Q&session_data=itct%3DCA4QvU4iEwjWlNWCw__KAhXMb04KHTjbDngo-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&length_seconds=1887&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FLqZKIDnRO9Q%2Fmqdefault.webp,author=ProJared&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FXTHvN9v55qA%2Fhqdefault.webp&short_view_count_text=&title=Shovel+Knight+Review&id=XTHvN9v55qA&session_data=itct%3DCA0QvU4iEwjWlNWCw__KAhXMb04KHTjbDngo-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&length_seconds=232&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FXTHvN9v55qA%2Fmqdefault.webp,author=Tal+Rimoni&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FdV-2g_t8uac%2Fhqdefault.webp&short_view_count_text=&title=Game+Grumps+Pokemon+FireRed+Best+Moments+Part+3&id=dV-2g_t8uac&session_data=itct%3DCAwQvU4iEwjWlNWCw__KAhXMb04KHTjbDngo-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&length_seconds=1984&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FdV-2g_t8uac%2Fmqdefault.webp,author=BaneOfXistence4&short_view_count_text=&title=Game+Grumps+Funniest+Moments%3A+Super+Mario+Sunshine&id=RiuBmShjbWM&session_data=itct%3DCAsQvU4iEwjWlNWCw__KAhXMb04KHTjbDngo-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&length_seconds=6555,author=Tal+Rimoni&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2F5sxprsW3eBY%2Fhqdefault.webp&short_view_count_text=&title=Game+Grumps+Kirby%27s+Epic+Yarn+Best+Moments+Part+1&id=5sxprsW3eBY&session_data=itct%3DCAoQvU4iEwjWlNWCw__KAhXMb04KHTjbDngo-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&length_seconds=3474&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2F5sxprsW3eBY%2Fmqdefault.webp"

ParticleCore commented 8 years ago

Can you enable YT+, refresh that same video page you had opened and share the same code it returns for ytplayer.config.args.rvs?

JourneyOver commented 8 years ago

@ParticleCore here you go, this is with YT+ enabled and the same video.

"short_view_count_text=&length_seconds=1236&endscreen_autoplay_session_data=itct%3D%2508%2516%2510%25E1%2592%2501%2522%2513%2508%25B8%25F1%25C8%2589%25C5%25FF%25CA%2502%2515FCN%250A%251D%25179%2500%25BE%2528%25F8%251D2%250Crelated-auto%26playnext%3D1%26autonav%3D1&author=GameGrumps&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2Fqx8IP4u2BOY%2Fmqdefault.webp&id=qx8IP4u2BOY&title=Animal+Crossing+Amiibo+Festival%3A+Finale+-+PART+6+-+Grumpcade+%28Ft.+SoloTravelBlog&session_data=itct%3DCBUQvU4iEwi48ciJxf_KAhVGQ04KHRc5AL4o-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2Fqx8IP4u2BOY%2Fhqdefault.webp,short_view_count_text=&length_seconds=3632&author=Tal+Rimoni&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FG5VFwC2uH2Y%2Fmqdefault.webp&id=G5VFwC2uH2Y&title=Game+Grumps+Link+to+the+Past+Best+Moments&session_data=itct%3DCBQQvU4iEwi48ciJxf_KAhVGQ04KHRc5AL4o-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FG5VFwC2uH2Y%2Fhqdefault.webp,short_view_count_text=&length_seconds=3265&author=Tal+Rimoni&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FWaAjbeGgGi0%2Fmqdefault.webp&id=WaAjbeGgGi0&title=Game+Grumps+Legend+of+Zelda+Best+Moments&session_data=itct%3DCBMQvU4iEwi48ciJxf_KAhVGQ04KHRc5AL4o-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FWaAjbeGgGi0%2Fhqdefault.webp,short_view_count_text=&length_seconds=2103&author=Tal+Rimoni&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FQVU-0ajMkWs%2Fmqdefault.webp&id=QVU-0ajMkWs&title=Game+Grumps+Dog+Island+Best+Moments&session_data=itct%3DCBIQvU4iEwi48ciJxf_KAhVGQ04KHRc5AL4o-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FQVU-0ajMkWs%2Fhqdefault.webp,short_view_count_text=&length_seconds=676&author=Game+Grumps+%C2%A9&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FtSpt6byu7o4%2Fmqdefault.webp&id=tSpt6byu7o4&title=Game+Grumps+%E2%84%A2+-+Shovel+Knight+Co-Op%3A+Winner%26%2339%3Bs+Mountain+-+PART+16+-+Game+Grumps+%E2%84%A2&session_data=itct%3DCBEQvU4iEwi48ciJxf_KAhVGQ04KHRc5AL4o-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FtSpt6byu7o4%2Fhqdefault.webp,short_view_count_text=&length_seconds=395&author=Penguin+Pandas&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FQTSkIGajFz4%2Fmqdefault.webp&id=QTSkIGajFz4&title=The+Co-Optional+Star+Destroyer&session_data=itct%3DCBAQvU4iEwi48ciJxf_KAhVGQ04KHRc5AL4o-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FQTSkIGajFz4%2Fhqdefault.webp,short_view_count_text=&length_seconds=1898&author=PlasmaBoom&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FhW7BqaxP5-g%2Fmqdefault.webp&id=hW7BqaxP5-g&title=Condensed+Game+Grumps+-+Castlevania+2%3A+Simon%27s+Quest+Compilation&session_data=itct%3DCA8QvU4iEwi48ciJxf_KAhVGQ04KHRc5AL4o-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FhW7BqaxP5-g%2Fhqdefault.webp,short_view_count_text=&length_seconds=1887&author=BestOf+LetsPlay&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FLqZKIDnRO9Q%2Fmqdefault.webp&id=LqZKIDnRO9Q&title=The+Best+of+Game+Grumps+-+Super+Mario+64&session_data=itct%3DCA4QvU4iEwi48ciJxf_KAhVGQ04KHRc5AL4o-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FLqZKIDnRO9Q%2Fhqdefault.webp,short_view_count_text=&length_seconds=232&author=ProJared&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FXTHvN9v55qA%2Fmqdefault.webp&id=XTHvN9v55qA&title=Shovel+Knight+Review&session_data=itct%3DCA0QvU4iEwi48ciJxf_KAhVGQ04KHRc5AL4o-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FXTHvN9v55qA%2Fhqdefault.webp,short_view_count_text=&length_seconds=1984&author=Tal+Rimoni&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FdV-2g_t8uac%2Fmqdefault.webp&id=dV-2g_t8uac&title=Game+Grumps+Pokemon+FireRed+Best+Moments+Part+3&session_data=itct%3DCAwQvU4iEwi48ciJxf_KAhVGQ04KHRc5AL4o-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2FdV-2g_t8uac%2Fhqdefault.webp,short_view_count_text=&length_seconds=6555&author=BaneOfXistence4&id=RiuBmShjbWM&title=Game+Grumps+Funniest+Moments%3A+Super+Mario+Sunshine&session_data=itct%3DCAsQvU4iEwi48ciJxf_KAhVGQ04KHRc5AL4o-B0yCWVuZHNjcmVlbkidppq8juT5ssgB,short_view_count_text=&length_seconds=3474&author=Tal+Rimoni&iurlmq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2F5sxprsW3eBY%2Fmqdefault.webp&id=5sxprsW3eBY&title=Game+Grumps+Kirby%27s+Epic+Yarn+Best+Moments+Part+1&session_data=itct%3DCAoQvU4iEwi48ciJxf_KAhVGQ04KHRc5AL4o-B0yCWVuZHNjcmVlbkidppq8juT5ssgB&iurlhq_webp=%2F%2Fi.ytimg.com%2Fvi_webp%2F5sxprsW3eBY%2Fhqdefault.webp"

ParticleCore commented 8 years ago

Finally I was able to replicate it

ss

And the culprit is really on that code you just shared, will work on a fix for it and try to post it as soon as I can.

JourneyOver commented 8 years ago

Sounds good, glad we finally got somewhere with the issue and that you were able to get it replicated as well, so you can work on it now ^_^

ParticleCore commented 8 years ago

@JourneyOver Could you test this userscript version and see if the problem persists?

https://gist.github.com/ParticleCore/057e73e26ab8ce818e77

pep0w commented 8 years ago

with that version, for me there is no video, it just shows a black box

JourneyOver commented 8 years ago

@ParticleCore Yep just comes up showing a black box with no controls/video at all like @q1k

ParticleCore commented 8 years ago

I've updated a new version, supposedly this one should do the trick. You can find it from the same link:

https://gist.github.com/ParticleCore/057e73e26ab8ce818e77

pep0w commented 8 years ago

it works for me

JourneyOver commented 8 years ago

@ParticleCore Yep it's working now from the looks of it

ParticleCore commented 8 years ago

I will then ship the update with the fix. In the meantime I will mark this bug as a duplicate of the original to keep things organized correctly.

Remember to use the original version again, instead of the test versions I shared, so that it can update correctly.

JourneyOver commented 8 years ago

@ParticleCore does seem like a few options don't correctly work though, two I know of right off the bat that aren't working are fit to page in theatre mode and the fit to max page width

ParticleCore commented 8 years ago

@JourneyOver It would be better if you could open a new issue for that, this one is already a bit saturated with too much information.

JourneyOver commented 8 years ago

Okay will do.

ParticleCore commented 8 years ago

Duplicate of https://github.com/ParticleCore/Particle/issues/221