ParticleCore / Particle

Home of the extension YouTube Plus that allows you to experience more on YouTube
Other
1.06k stars 228 forks source link

Skip ad button is gone when Youtube Plus actived #57

Closed hamkah2c closed 9 years ago

hamkah2c commented 9 years ago

Browser Name: Chrome

Browser Version: 44.0.2403.155 m

Operating System: Win7 64 bit

Software Type: Extension

Software Version: 0.4.9

Problem Description: When Loading video, video ads is loading, but, the button for skipping ads is gone. I have disable all my extension except Youtube Plus, but the button is still gone.

Steps to reproduce: ...

Additional details: My youtube language is English (UK) And here my setting:

 {
  "BLK_ON": false,
  "GEN_BLUE_GLOW": true,
  "GEN_BTTR_NTF": true,
  "GEN_CHN_DFLT_PAGE": "videos",
  "GEN_CMPT_TTLS": false,
  "GEN_DSBL_ADS": true,
  "GEN_DSB_HVRC": true,
  "GEN_GRID_SRCH": false,
  "GEN_GRID_SUBS": true,
  "GEN_HDE_CHN_SDBR": false,
  "GEN_HDE_RECM_SDBR": false,
  "GEN_HDE_SRCH_SDBR": false,
  "GEN_HIDE_FTR": true,
  "GEN_INF_SCRL": true,
  "GEN_REM_APUN": true,
  "GEN_SDBR_ON": false,
  "GEN_SPF_OFF": false,
  "GEN_SUB_LIST": true,
  "GEN_YT_LOGO_LINK": true,
  "VID_DESC_SHRT": true,
  "VID_DFLT_QLTY": "large",
  "VID_END_SHRE": false,
  "VID_HIDE_COMS": "0",
  "VID_HIDE_DETLS": false,
  "VID_LAYT_AUTO_PNL": true,
  "VID_PLR_ADS": false,
  "VID_PLR_ALVIS": false,
  "VID_PLR_ANTS": false,
  "VID_PLR_ATPL": true,
  "VID_PLR_CC": false,
  "VID_PLR_DASH": false,
  "VID_PLR_DYN_SIZE": true,
  "VID_PLR_FIT": true,
  "VID_PLR_FIT_WDTH": "1000px",
  "VID_PLR_INFO": false,
  "VID_PLR_SIZE_MEM": true,
  "VID_PLR_VOL_MEM": false,
  "VID_PLST_ATPL": true,
  "VID_PLST_RVRS": true,
  "VID_PLST_SEP": true,
  "VID_POST_TIME": true,
  "VID_SDBR_ALGN": "1",
  "VID_SUB_ADS": false,
  "VID_TTL_CMPT": false,
  "VID_VID_CNT": true,
  "VID_VOL_WHEEL": false,
  "advOpts": false,
  "blacklist": {},
  "frameStep": false,
  "fullBrs": false,
  "lightsOut": false,
  "plApl": false,
  "plRev": false,
  "theaterMode": true,
  "volLev": 50
}

Screenshot: image

ParticleCore commented 9 years ago

Thank you for bringing this to my attention, I have confirmed the issue on my end and will try to push a fix as soon as possible.

ParticleCore commented 9 years ago

I have released a fix for this issue, let me know if it works correctly now.

hamkah2c commented 9 years ago

Yes, this work correctly now, but there is new bug about text ads do I have open new issue?

ParticleCore commented 9 years ago

There's no need, I managed to fix the problem in the meantime. Will update the new version and let you know when it is ready.

ParticleCore commented 9 years ago

Version 0.5.2 is available for update, let me know if the overlay ads issue has been fixed.

Eisys commented 9 years ago

Hey @ParticleCore , I didn't want to make a new issue, so Im gonna ask here. Is there an update checker in the addon? It seems you're updating quite often and it'd be nice to be up to date all the time. Or is it just easier to come on this site and check the latest version?

ParticleCore commented 9 years ago

@Eisys No, due to too many complications I've opted not to add such feature for now. If you are using the Firefox Add-on version then I am sorry, but you will have to check for updates manually by visiting the page, until the add-on is reviewed auto-updates are disabled by Mozilla.

For the other options, userscripts are usually the fastest to update, but both userscript managers and the Chrome extension manager have a built in feature to check for updates, so it shouldn't suffer too much of a delay.

For example, in Greasemonkey all you have to do is right click the YT+ userscript and choose either Find updates or Force find updates.

In Tampermonkey you have to open the dashboard and click on the Last updated time in front of YT+, or check YT+ and choose from the field options on top Trigger update.

In Chrome, visit the extensions' page and click Developer mode and then click Update extensions now.

hamkah2c commented 9 years ago

Yup, now it's perfect :D Thank you for this great extension :+1: