search

Particular / NServiceBus.AwsLambda.Sqs

Integration package for AWS Lambda using SQS as transport
Other
1 stars 1 forks source link

Do not disable delayed delivery since currently the FIFO queue is anyway always required by the transport #347

Closed danielmarbach closed 8 months ago

danielmarbach commented 8 months ago

The comment in the code was misleading since the delayed message pump is always initialized which checks for the existence of the fifo queue.

andreasohlund commented 8 months ago

FYI The failing test has been fixed in #292 so either wait for that to be merged or merge this one into that branch

The docs seems to be a bit of in regards to serializer and need for the error queue to be set so I will fix that

https://docs.particular.net/nservicebus/hosting/aws-lambda-simple-queue-service/

danielmarbach commented 8 months ago

@andreasohlund would you be able to cherry-pick this change over there?

andreasohlund commented 8 months ago

I've cherry-picked the commit, I'll take care of updating the docs.

https://docs.particular.net/nservicebus/hosting/aws-lambda-simple-queue-service/#configuration-delayed-retries only thing that needs to change right?

danielmarbach commented 8 months ago

That's all I'm aware of yes

bording commented 8 months ago

Merged as part of #292