Closed particularbot closed 7 months ago
~FYI, this may require a release.~ Nope, see below.
Update: Although this PR had to change the component code itself to get all tests to pass, a new release isn't required.
The bug was due to a throw;
out of a nested try
/catch
. When compiled with the 8.0 SDK, the throw
begins throwing the outer exception, not the inner one, resulting in a different exception observed up the call stack.
But in this PR a test was conducted using the 1.1.1 package which was built using the .NET 7.0 SDK, and when using those bits, the tests all pass when executed on each of the 6.0, 7.0, and 8.0 runtimes, proving that the bug is a compiler bug, not a runtime bug, and all the previously-built packages are bug-free even when executed on the .NET 8 runtime.
dotnet-version
to8.0.x
,7.0.x
,6.0.x
dotnet-version
to8.0.x
(net481);net6.0;net7.0;net8.0
pwsh
as default shell for CI and Release workflowsParticular/push-octopus-package-action@main
with commentactions/checkout
tov4.1.1
actions/setup-dotnet
tov4.0.0
actions/upload-artifact
tov4.3.1
Particular/run-tests-action
tov1.7.0
Particular/push-octopus-package-action
tov2.0.0
azure/login
tov2.0.0
Particular.Approvals
to0.3.0
if using0.2.0
GitHubActionsTestLogger
to2.3.3
Microsoft.NET.Test.Sdk
to17.9.0
NUnit
to3.14.0
NUnit3TestAdapter
to4.5.0