Particular / NServiceBus.AwsLambda.Sqs

Integration package for AWS Lambda using SQS as transport
Other
1 stars 1 forks source link

Updates for .NET 8 - release-1.1 #351

Closed particularbot closed 7 months ago

particularbot commented 7 months ago
DavidBoike commented 7 months ago

~FYI, this may require a release.~ Nope, see below.

DavidBoike commented 7 months ago

Update: Although this PR had to change the component code itself to get all tests to pass, a new release isn't required.

The bug was due to a throw; out of a nested try/catch. When compiled with the 8.0 SDK, the throw begins throwing the outer exception, not the inner one, resulting in a different exception observed up the call stack.

But in this PR a test was conducted using the 1.1.1 package which was built using the .NET 7.0 SDK, and when using those bits, the tests all pass when executed on each of the 6.0, 7.0, and 8.0 runtimes, proving that the bug is a compiler bug, not a runtime bug, and all the previously-built packages are bug-free even when executed on the .NET 8 runtime.