Particular / NServiceBus.Azure

Transports and storage for Windows Azure
https://docs.particular.net/nservicebus/azure/
Other
10 stars 15 forks source link

Review version policy Newtonsoft.Json #300

Open yvesgoeleven opened 7 years ago

yvesgoeleven commented 7 years ago

Connects to https://github.com/Particular/NServiceBus.Azure/issues/318

Current: Fixed Major Range

Used in

yvesgoeleven commented 7 years ago

Suggestion: Open Major Range [9.0.0, )

boblangley commented 7 years ago

Agreed, Open Major Range 👍

Scooletz commented 7 years ago

It might hit us back but 👍 is better than blocking people from bumping this up.

danielmarbach commented 7 years ago

In the fence on this one. Since sometimes we hook into the guts of the serializer this seems to be too dangerous since those interfaces can change in a major. I'd rather deal with minor version bumps on all our azure offerings. So 👎

yvesgoeleven commented 7 years ago

@danielmarbach where do we do this?

yvesgoeleven commented 7 years ago

@danielmarbach how about a closed range [9.0.0.0, 11.0.0.0) that we extend after testing any new major coming from newtonsoft?

yvesgoeleven commented 7 years ago

Or as @SimonCropp suggested, replace it with https://msdn.microsoft.com/en-us/library/system.runtime.serialization.json.datacontractjsonserializer.aspx

danielmarbach commented 7 years ago

Or ILMerge repack newtonsoft json

On Thu, Jun 8, 2017 at 2:33 PM Yves Goeleven notifications@github.com wrote:

Or as @SimonCropp https://github.com/simoncropp suggested, replace it with https://msdn.microsoft.com/en-us/library/system.runtime.serialization.json.datacontractjsonserializer.aspx

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Particular/NServiceBus.Azure/issues/300#issuecomment-307089385, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKosjCTNYhFU2EeF6-ViQSCZUXmrcUEks5sB-oZgaJpZM4NpTLO .

yvesgoeleven commented 7 years ago

Will be promoted to platdev

Scooletz commented 7 years ago

Could you link the platdev issue @yvesgoeleven ?