Particular / NServiceBus.Azure

Transports and storage for Windows Azure
https://docs.particular.net/nservicebus/azure/
Other
10 stars 15 forks source link

Samples using Azure Storage require binding redirect update #311

Closed SeanFeldman closed 7 years ago

SeanFeldman commented 7 years ago

When Azure showcase was updated, the rest of sample that rely on Storage did not got smoke tested and binding redirects might be invalid. Issue #308 was raised, but it didn't address all samples.

updated the cloud showcase to NServiceBus.Azure.Transports.WindowsAzureStorageQueues.7.3.0 and Microsoft.WindowsAzure.Storage.8.1.4.0 and Newtonsoft.Json.10.0.3 and NServiceBus.Persistence.AzureStorage.1.4.0 you may want to smoke test
SeanFeldman commented 7 years ago

@yvesgoeleven haven't you worked on updating the samples already?

yvesgoeleven commented 7 years ago

@SeanFeldman I smoketested them earlier this week yes, they worked fine including the showcase, did I forget any?

yvesgoeleven commented 7 years ago

@SeanFeldman looks like @SimonCropp updated to 8.2.1 a day after I performed the smoke tests for 8.2.0, the ASQ sample is indeed broken now because of wrong binding redirect.

https://github.com/Particular/docs.particular.net/commit/58ffe34a74be538a573dd56569891667306d815f

I'll fix it, but we need to redo all the smoketests and figure out a better way to stay in sync. It takes a few hours to open/compile/run all the samples, it is impossible to keep up this way (and work on TFs, squads etc at the same time)

SimonCropp commented 7 years ago

u dont need to smoke test all of them. just one will do

yvesgoeleven commented 7 years ago

PR: https://github.com/Particular/docs.particular.net/pull/3011

yvesgoeleven commented 7 years ago

@SimonCropp but then we won't be able to prevent some samples from not working, like this one, is that acceptable?

SimonCropp commented 7 years ago

the binding redirect issue should be fixable with a search and replace. then smoke test on to confirm the change

yvesgoeleven commented 7 years ago

with a search and replace

what tool can do that?

SimonCropp commented 7 years ago

any text editor

SeanFeldman commented 7 years ago

Any tool won't work - notepad won't do it with multiple files 😉

I found VS code very handy with that.

On Jul 28, 2017 07:10, "Simon Cropp" notifications@github.com wrote:

any text editor

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Particular/NServiceBus.Azure/issues/311#issuecomment-318647764, or mute the thread https://github.com/notifications/unsubscribe-auth/ABP7tt81XmFor8FGrpX5GjxkyeHC8aGfks5sSd3WgaJpZM4OXsJr .