Closed SeanFeldman closed 7 years ago
@yvesgoeleven haven't you worked on updating the samples already?
@SeanFeldman I smoketested them earlier this week yes, they worked fine including the showcase, did I forget any?
@SeanFeldman looks like @SimonCropp updated to 8.2.1 a day after I performed the smoke tests for 8.2.0, the ASQ sample is indeed broken now because of wrong binding redirect.
https://github.com/Particular/docs.particular.net/commit/58ffe34a74be538a573dd56569891667306d815f
I'll fix it, but we need to redo all the smoketests and figure out a better way to stay in sync. It takes a few hours to open/compile/run all the samples, it is impossible to keep up this way (and work on TFs, squads etc at the same time)
u dont need to smoke test all of them. just one will do
@SimonCropp but then we won't be able to prevent some samples from not working, like this one, is that acceptable?
the binding redirect issue should be fixable with a search and replace. then smoke test on to confirm the change
with a search and replace
what tool can do that?
any text editor
Any tool won't work - notepad won't do it with multiple files 😉
I found VS code very handy with that.
On Jul 28, 2017 07:10, "Simon Cropp" notifications@github.com wrote:
any text editor
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Particular/NServiceBus.Azure/issues/311#issuecomment-318647764, or mute the thread https://github.com/notifications/unsubscribe-auth/ABP7tt81XmFor8FGrpX5GjxkyeHC8aGfks5sSd3WgaJpZM4OXsJr .
When Azure showcase was updated, the rest of sample that rely on Storage did not got smoke tested and binding redirects might be invalid. Issue #308 was raised, but it didn't address all samples.