search

Particular / NServiceBus.CustomChecks

Enables sending state of custom checks to ServicePulse
Other
1 stars 0 forks source link

CustomCheck Escaped Exceptions provide no meaningful data in servicepulse #48

Open TraGicCode opened 4 years ago

TraGicCode commented 4 years ago

For users writing custom checks, if they have an exception that escapes their CustomCheck, the exception message is logged in the endpoints log BUT the message sent to ServiceControl is confusing and not helpful.

https://github.com/Particular/NServiceBus.CustomChecks/blob/a7b89fb4ce2fa1293432ed6bef53842f496dc3c8/src/NServiceBus.CustomChecks/TimerBasedPeriodicCheck.cs#L38-L42

My Suggestion is to replace implementation failed to run. to something along the lines of custom check failed to run due to the following unhandled exception : ${Exception.Message}

TraGicCode commented 4 years ago

If the above is done, I would then recommend in the documentation to state. If an unhandled exception happens the exception message will be shown. We recommend preventing this by catching all unhandled exceptions so that you can customize the error message to the flexibility of your needs.