search

Particular / NServiceBus.Metrics

NServiceBus.Metrics provides a convenient way of gathering metrics like processing time or critical time.
Other
5 stars 2 forks source link

Metrics captured for processing time, critical time , message failed and message succeded are incorrect. #174

Open andreasohlund opened 3 years ago

andreasohlund commented 3 years ago

Since we trigger on OnPipelineCompleted metrics the time it takes the transport to push outgoing messages into the queueing system and acknowledge the message. This means that the metrics can be significantly skewed. We also trigger the counters for message failed and message succeded in the same event so they happen to soon as well in addition to potentially be incorrect should something fail during recoverability or when the transport completes the transport transactions.

andreasohlund commented 3 years ago

Related to https://github.com/Particular/NServiceBus/issues/3565 which is similar since it results on the headers on the audit message being wrong

andreasohlund commented 3 years ago

Will likely be fixes as we complete https://github.com/Particular/NServiceBus/pull/5936 and update downstreams

DavidBoike commented 3 years ago

That change was reverted for NServiceBus 8.

https://github.com/Particular/NServiceBus/pull/5959 is a spike to show how this bug may be fixed in the future.