SimonCropp
commented
9 years ago @warrenrumak having trouble reproducing this one
I wrote a handler that does this
class MyHandler : IHandleMessages<MyMessage>
{
public void Handle(MyMessage message)
{
Foo();
}
static void Foo()
{
Bar();
}
static void Bar()
{
throw new Exception("sdfsdf");
}
}And the stack trace I got was this
System.Exception: sdfsdf
at MyHandler.Bar() in c:\Code\ConsoleApplication2\ConsoleApplication2\ProgramService.cs:line 80
at MyHandler.Foo() in c:\Code\ConsoleApplication2\ConsoleApplication2\ProgramService.cs:line 75
at MyHandler.Handle(MyMessage message) in c:\Code\ConsoleApplication2\ConsoleApplication2\ProgramService.cs:line 70
at NServiceBus.Unicast.HandlerInvocationCache.Invoke(Object handler, Object message, Dictionary`2 dictionary) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\Unicast\HandlerInvocationCache.cs:line 63
at NServiceBus.Unicast.Behaviors.InvokeHandlersBehavior.Invoke(HandlerInvocationContext context, Action next) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\Unicast\Behaviors\InvokeHandlersBehavior.cs:line 29
at NServiceBus.Pipeline.BehaviorChain`1.InvokeNext(T context) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\Pipeline\BehaviorChain.cs:line 51 at NServiceBus.Pipeline.BehaviorChain`1.Invoke(T context) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\Pipeline\BehaviorChain.cs:line 34
at NServiceBus.Pipeline.PipelineExecutor.Execute[T](BehaviorChain`1 pipelineAction, T context) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\Pipeline\PipelineExecutor.cs:line 139
at NServiceBus.Unicast.Behaviors.LoadHandlersBehavior.Invoke(ReceiveLogicalMessageContext context, Action next) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\Unicast\Behaviors\LoadHandlersBehavior.cs:line 37
at NServiceBus.Pipeline.BehaviorChain`1.InvokeNext(T context) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\Pipeline\BehaviorChain.cs:line 51 at NServiceBus.Pipeline.BehaviorChain`1.Invoke(T context) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\Pipeline\BehaviorChain.cs:line 34
at NServiceBus.Pipeline.PipelineExecutor.Execute[T](BehaviorChain`1 pipelineAction, T context) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\Pipeline\PipelineExecutor.cs:line 139
at NServiceBus.Unicast.Messages.ExecuteLogicalMessagesBehavior.Invoke(ReceivePhysicalMessageContext context, Action next) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\Unicast\Messages\ExecuteLogicalMessagesBehavior.cs:line 28
at NServiceBus.Pipeline.BehaviorChain`1.InvokeNext(T context) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\Pipeline\BehaviorChain.cs:line 51 at NServiceBus.Pipeline.BehaviorChain`1.InvokeNext(T context) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\Pipeline\BehaviorChain.cs:line 62
at NServiceBus.UnitOfWork.UnitOfWorkBehavior.Invoke(ReceivePhysicalMessageContext context, Action next) in c:\BuildAgent\work\31f8c64a6e8a2d7c\src\NServiceBus.Core\UnitOfWork\UnitOfWorkBehavior.cs:line 24Which seems correct.
Can you provide a way to reproduce your issue?
Where are you looking at the stack trace? In the debugger, in the log file or elsewhere?
Just to confirm you are using 4.6.3?
Wwhat change are you referring to here
I also see that further changes were made in this area a few weeks later to avoid the bad practice of doing catch (Exception e) { throw e; } but that code has not made it into a 4.6 branch release
mlidbom
andreasohlund
warrenrumak
After upgrading from 4.4.2, all we get for a stack trace when an exception happens in a message handler is:
It's pretty clear that this is a consequence of the badly-judged implementation of avoiding deeply-nested stack traces (d4795bd99164d29a7559b2826e4eed5451418678). I also see that further changes were made in this area a few weeks later to avoid the bad practice of doing catch (Exception e) { throw e; } but that code has not made it into a 4.6 branch release. It would be nice if you did -- my only alternative right now seems to be to wrap all handlers with a try/catch block and do my own error logging.