search

Particular / NServiceBus

Build, version, and monitor better microservices with the most powerful service platform for .NET
https://particular.net/nservicebus/
Other
2.1k stars 647 forks source link

Remove obsolete distributor config in UnicastBusConfig #3426

Closed timbussmann closed 8 years ago

timbussmann commented 8 years ago

These two properties on UnicastBusConfig are unused:

related to https://github.com/Particular/NServiceBus/issues/3424 related to https://github.com/Particular/NServiceBus/issues/1465

SzymonPobiega commented 8 years ago

@timbussmann they are not used. How do we handle obsoleting the config properties? WARN log entry on startup?

timbussmann commented 8 years ago

@SzymonPobiega obsoleting the property to make it unavailable from a code api perspective and throw an exception when the property has a value from the config file, e.g. something like here: https://github.com/Particular/NServiceBus/pull/3418

janovesk commented 8 years ago

Backtracking on this. This is still in use. We intend to support V6 endpoints as workers for a V5 distributor to ease transition away from distributor. These two properties is one of the ways you can connect a worker with the distributor, the other is masternode config.

SzymonPobiega commented 8 years ago

The V6 worker setup API looks currently like this: https://github.com/Particular/NServiceBus/blob/develop/src/NServiceBus.Core/Routing/Legacy/ConfigureMSMQDistributor.cs so it does not use the config section. There is, however, on open question if we should actually support fully distributor in V6.

janovesk commented 8 years ago

In that case I withdraw my objection :)

andreasohlund commented 8 years ago

There is, however, on open question if we should actually support fully distributor in V6.

@SzymonPobiega has this been decided on?

@mat-mcloughlin do you plan to work on this?

SzymonPobiega commented 8 years ago

@andreasohlund not sure. @SimonCropp challenged me to prepare a draft of an announcement telling the customers that there will be no V6 version of distributor and that they need to switch to a stand-alone distributor scenario if they used distributor in-process. Here's the draft: https://github.com/Particular/NServiceBus/issues/3437

mat-mcloughlin commented 8 years ago

@andreasohlund My PR for obsoleting this properly was pulled in a while back now and I opened up a doco PR for it. I think @mikeminutillo is going to take it off my hands now as it required a bit more knowledge of the distributor than I have at the moment

Doco PR https://github.com/Particular/docs.particular.net/pull/1197

danielmarbach commented 8 years ago

@mat-mcloughlin Ok I assigned @mikeminutillo

mikeminutillo commented 8 years ago

I also have little context about the distributor and had just intended to update the doco PR. If someone can provide me with the context I need and review the changes I make, I'm happy to take a look.

It sounds like obsoleting the two config properties has already been done and that we want to drive users towards the code-first configuration API. This is in line with the doco PR. Is that the end of this?

timbussmann commented 8 years ago

closing this one as code changes were merged and doc PR exists.