search

Particular / NServiceBus

Build, version, and monitor better microservices with the most powerful service platform for .NET
https://particular.net/nservicebus/
Other
2.09k stars 647 forks source link

Scan assemblies containing types that match the IMessageConvention #6968

Closed evt-jonny closed 7 months ago

evt-jonny commented 8 months ago

https://github.com/Particular/NServiceBus/issues/6967

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

mikeminutillo commented 8 months ago

@evt-jonny @bbrandt thanks for the PR. We will evaluate it and make a decision about what to do.

Most NServiceBus endpoint applications end up with a lot of assemblies in their App Domains which is part of the reason we aggressively filter the list that we perform assembly scanning on. Take a look in the startup diagnostic file of an endpoint and you will see the list of assemblies that were skipped. This change has the potential to slow down endpoint creation significantly as we would need to perform type-scanning on all assemblies.

evt-jonny commented 8 months ago

This change has the potential to slow down endpoint creation significantly as we would need to perform type-scanning on all assemblies.

@mikeminutillo totally agree, see my response in the original issue.

mikeminutillo commented 7 months ago

@evt-jonny @bbrandt Thank you for your PR. After discussing this internally, we have too many concerns about the impact on endpoint startup time when someone opts in to this flag.

Given that you currently have a viable workaround to get you unstuck we have decided not to merge this.

We have added the issue to our backlog for deeper architectural review at some point in a future release.