Particular / NServiceBus

Build, version, and monitor better microservices with the most powerful service platform for .NET
https://particular.net/nservicebus/
Other
2.07k stars 648 forks source link

The automatic rate-limiting feature can unknowingly cripple endpoints if there's a bug in the user's system #7018

Open lailabougria opened 4 months ago

lailabougria commented 4 months ago

Describe the suggested improvement

Is your improvement related to a problem? Please describe.

The automatic rate-limiting feature, doesn't allow users to filter the errors for which to invoke/allow this behavior.

This means that if there's a bug in user code, it could cause a wide range of exceptions in their environment. This triggers the automatic rate-limiting feature, limiting the endpoint to minimum processing power. However, the endpoint can never exit the automatic rate-limiting since there's a bug in a much-used message type, meaning that other message types that could be successfully processed aren't due to the concurrency being down.

This could, in turn, cause other exceptions, for example, the queue filling up, causing errors upstream.

Describe the suggested solution

Describe alternatives you've considered

Additional Context

No response