Particular / NServiceBus

Build, version, and monitor better microservices with the most powerful service platform for .NET
https://particular.net/nservicebus/
Other
2.07k stars 650 forks source link

Ensure that the TTBR tests do not end just after the feature startup is done #7062

Closed tmasternak closed 1 month ago

tmasternak commented 1 month ago

Symptoms

Acceptance tests for TTBR always pass.

Who's affected

None of the users are affected.

Downstream components maintained by Particular using the tests.

Root cause

Acceptance tests for TTBR do not specify Done condition and use the default Done condition i.e. () => true. This causes the test to end immediately, just after the OnStart method of FeatureStartupTask finishes.

As a result, the tests that check if messages with TTBR are not delivered when the expiry time elapses finish with false positive results.