search

Particular / ServiceInsight

Advanced debugging for NServiceBus
http://particular.net/serviceinsight
Other
16 stars 32 forks source link

ServiceControl - Saga Data Report Seems To Always Show In Bound Values Not Updated Values #309

Open johnsimons opened 10 years ago

johnsimons commented 10 years ago

Raised by @JeffreyAllenMiller Migrated from by https://github.com/Particular/ServiceControl/issues/321

Let me start by saying the Saga View is truly an awesome enterprise tool. This will absolutely empower teams to embrace Saga's now that we true transparency as to what is occurring behind the scenes.

That said, I think there is one area that could be improved. It looks as though the Saga Properties always represent the state of the Saga Data entering the handler with the exception of the message that starts the handler. I believe there would be some value in providing the ability to view the Inbound and Outbound Saga Data as it relates to a specific message being handled. I realize that I can look at the next message in the workflow to see the Outbound Saga Data, but that is not as intuitive, plus what happens if the next event or command has yet to execute and we are troubleshooting something. We could be using the Saga Data to drive next steps or business rules and we would have no idea what state it currently is in because we do not display the outbound Saga Data. I could figure out how to Query RavenDB directly to figure it out, but with a tool of this caliber that just seem silly. I would argue there is even value in displaying both for the last handler for the workflow.

dannycohen commented 10 years ago

@JeffreyAllenMiller - I believe what your looking for is before and after (or latest and previous) values per property. There is a feature in the backlog that we refer to as "long properties view" that allows to open a window for large (or any) properties, and view latest and previous values.

See :https://github.com/Particular/ServiceInsight/issues/78#issuecomment-30371123

Is this close to what you have in mind ?

// CC @indualagarsamy , @sergioc , @udidahan

JeffreyAllenMiller commented 10 years ago

Yes that is similar. I think it only makes sense to see the saga data that entered a handle and the saga data that exited the handler On May 8, 2014 9:09 AM, "Danny Cohen" notifications@github.com wrote:

@JeffreyAllenMiller https://github.com/JeffreyAllenMiller - I believe what your looking for is before and after (or latest and previous) values per property. There is a feature in the backlog that we refer to as "long properties view" that allows to open a window for large (or any) properties, and view latest and previous values.

See :#78 (comment)https://github.com/Particular/ServiceInsight/issues/78#issuecomment-30371123

Is this close to what you have in mind ?

// CC @indualagarsamy https://github.com/indualagarsamy , @sergiochttps://github.com/sergioc, @udidahan https://github.com/udidahan

— Reply to this email directly or view it on GitHubhttps://github.com/Particular/ServiceInsight/issues/309#issuecomment-42547452 .

dannycohen commented 10 years ago

I think it only makes sense to see the saga data that entered a handle and the saga data that exited the handler

That was the original plan (show "All" and "Updated" and for the updated properties, show "before" and "after" values). However, this proved to be problematic from both a UI/UX perspective (a lot of info in a crowded place...) and from a performance response time perspective (lots of data to query and correlate by default.

So we opted to address both these issues by showing the data in a separate window (thereby solving the crowded UI issue) and on-demand (addressing the response time issue).

Make sense ?