Particular / ServiceInsight

Advanced debugging for NServiceBus
http://particular.net/serviceinsight
Other
16 stars 32 forks source link

Sequence diagram style and behavior adjustments #517

Closed HEskandari closed 8 years ago

HEskandari commented 8 years ago

After a review with @sergioc we came up with the following issues that needs to be fixed before the release:

No going to do:

johnsimons commented 8 years ago

Regarding the " Add max length to handler label and show ellipsis (...) in the middle, if possible.", we have decided against ... as much as possible and in this scenario we don't need them. All we need is to ensure the text is readable when overlaps a line, and that can be easily achieved by assigning a white background to the label.

sergioc commented 8 years ago

we have decided against

@johnsimons I don't remember being part of the decision process...

All we need is to ensure the text is readable when overlaps a line, and that can be easily achieved by assigning a white background to the label.

... but let's see how that will look like.

HEskandari commented 8 years ago

@sergioc could you conver the loopback.svg to Geometry data? I can see that it has Polyline and Polygon inside, which makes it a bit different (and unusable in my case). e.g. this is for "Commands":

M 0,0 M 32,32 M 0,16 A 6,6 0 1 1 12,16 A 6,6 0 1 1 0,16   M 14,13 v6 h10 v2 L32,16 L24,11 v2 z
johnsimons commented 8 years ago

I don't remember being part of the decision process

@sergioc yes that is right, the taskforce made that decision in the Aussie timezone.

sergioc commented 8 years ago

@HEskandari updated loopback* icons in same location, lemme know if you need further adjustments.

sergioc commented 8 years ago

@johnsimons can you add here a screenshot of a sequence diagram showing various handler labels overlapping endpoint spines to see the impact of the overlapping labels?

johnsimons commented 8 years ago

@sergioc here it is image

We need to add more padding but it should convey the message

sergioc commented 8 years ago

@johnsimons That does not give me an idea of what I asked for. I see only one handler in one tiny screenshot cropping.

Can you please provide a screenshot showing a diagram with various handler labels overlapping endpoint spines to see the impact of the overlapping labels?

johnsimons commented 8 years ago

Sorry @sergioc not following, the screen shot shows an overlapping, wasn't that what you are after ? Here is a zoomed view: image

johnsimons commented 8 years ago

All done