Particular / ServicePulse

Production monitoring for distributed systems.
https://docs.particular.net/servicepulse/
Other
33 stars 27 forks source link

Allow free form user comments for retry groups #393

Closed indualagarsamy closed 3 years ago

indualagarsamy commented 7 years ago

See the user feedback here: https://groups.google.com/forum/#!topic/particularsoftware/TdkL7i36ioA

It would be great if there could be a free form field at the message group level where we could leave comments about what actions had been taken.

janovesk commented 7 years ago

Interesting.. What should we connect it to? The current open group? What if you request a retry for the group and new, similar messages make the group reappear later? Should the "old" comment pop back up, or was that "cleared" by the retry operation?

stimms commented 7 years ago

Great questions. I would say that the message should be cleared by a retry all but not with a retry of a single message. In our scenario we see errors which are caused by upstream processes which are failing. Until they are corrected we just need to keep the ops team, who work 24/7, aware that there is no point in retrying. We use to use labels in MSMQ for this purpose. I'd tie the message to the current group and I wouldn't revive the message if the group is cleared and then new messages come in.

WilliamBZA commented 7 years ago

Connected to this suggestion: https://github.com/Particular/ServicePulse/issues/164

Perhaps an approach that allows comments on groups, operations, endpoints, custom checks, etc might be a good initiative.

sergioc commented 7 years ago

Could we somehow have a generic ability to add comments to any SC event and then expose where appropriate in SP?

efleming18 commented 7 years ago

@WilliamBZA Any movement on this one? I see it connected to https://github.com/Particular/ServicePulse/issues/164 so I guess any movement on either?

WilliamBZA commented 7 years ago

@efleming18 I'm trying to come up with a way to add this feature without adding too much additional load on RavenDb. It's a bit tricky because of how we like the groups to the actual failed messages.

On the assumption that I manage to come up with something clever for the storage, there's a few decisions that should be made first:

@stimms already gave a pretty good example of how this would be used, perhaps we can come up with a few other scenarios so that we can trim down the requirements a bit more.

WojcikMike commented 6 years ago

There is an ask for similar feature in #164

WojcikMike commented 3 years ago

We added the ability to comment on a group in version 1.30 of ServicePulse. Close this issues