Particular / docs.particular.net

All content for ParticularDocs
https://docs.particular.net
Other
103 stars 301 forks source link

Problematic 'Performance Counters' doco #3191

Closed SimonCropp closed 6 years ago

SimonCropp commented 7 years ago

ping @Particular/metrics-maintainers

this https://docs.particular.net/nservicebus/operations/performance-counters?version=perfcounters_1 uses the language from when the perf coutners was still in the core. eg "Critical Time Added in: Version 3" but i am looking at the version 1 page. so what is version 3?

version 1 explains the counters https://docs.particular.net/nservicebus/operations/performance-counters?version=perfcounters_1#sla-violation-countdown but version 1.1 does not https://docs.particular.net/nservicebus/operations/performance-counters?

weralabaj commented 7 years ago

the simple fix could be to change to "Added in NServiceBus Version 3", or instead of using the "Added" convention, just list available perf counters for each version

SimonCropp commented 7 years ago

@weralabaj but those sections are not showing up in the newest doco

weralabaj commented 7 years ago

I commented only on the first part of the issue, either way I can help with this if needed.

SimonCropp commented 7 years ago

@weralabaj i would rather the @Particular/metrics-maintainers own it and only pull u in if they need help

dvdstelt commented 7 years ago

Can't we just lose the version 3 & version 4 references? Those are in versions that are not supported in any case. It's really outdated information. Then we'd only need specific information for NSB 6 and "version" 1 or higher details.

SimonCropp commented 7 years ago

Can't we just lose the version 3 & version 4 references

@dvdstelt until this is decided we cannot burn old doco https://github.com/Particular/CustomerSuccess/issues/548

weralabaj commented 7 years ago

ping @Particular/metrics-maintainers any comments?

dvdstelt commented 7 years ago

I will pick this up

weralabaj commented 6 years ago

Ping @dvdstelt ;)

dvdstelt commented 6 years ago

This can be closed, it has become irrelevant after the recent changes. I was waiting for that PR to be merged! :-)