search

Particular / docs.particular.net

All content for ParticularDocs
https://docs.particular.net
Other
103 stars 301 forks source link

Feedback: 'NServiceBus Host Upgrade Version 6 to 7' #5154

Closed bennettwork closed 1 week ago

bennettwork commented 3 years ago

Feedback for 'NServiceBus Host Upgrade Version 6 to 7' https://docs.particular.net/nservicebus/upgrades/host-6to7

Location in GitHub: https://github.com/Particular/docs.particular.net/blob/master/nservicebus/upgrades/host-6to7.md

Shouldn't there be a page for "NServiceBus Host Upgrade Version 5 to 6"?

It's confusing that the first line of "NServiceBus Host Upgrade Version 6 to 7" says

This is part of the NServiceBus Upgrade Guide from Version 5 to 6...

The mismatching vesion numbers are confusing. Anyway, there currently appears to be no ducumention about upgrading from NServiceBus Host 5. I think there should be!

ramonsmits commented 3 years ago

@bennettsolnet you are right that is seems an upgrade guide from Host 5 to 6 seems to be missing.

However, Host v6 is part of Core v5. We follow Semver which required incrementing the major version because we introduced a breaking changes in Host v6:

https://github.com/Particular/NServiceBus.Host/releases/tag/6.0.0

The breaking changes is:

Previous versions enabled the performance counters Critical Time and SLA violation countdown by default.

I do not expect any other issues and because there do not seem to be any "compile" issues it seems the upgrade guide was skipped.

Thanks for making us aware of this gap and I'll create the missing upgrade guide with this info at a later moment.

soujay commented 1 week ago

As per the document , NServiceBus.Host version 5 and version 6 , both target NSB 5.x which is out of support. We didn't provide an upgrade guide for NServiceBus.Host going from 5 to 6 as there was not any breaking change