search

Particular / setup-azureservicebus-action

MIT License
0 stars 0 forks source link

update deprecated actions #6

Closed soujay closed 1 year ago

soujay commented 1 year ago

As part of GitHub Actions: save-state and set-output are deprecated #1135, this PR updates to Node16 and removes deprecated actions

danielmarbach commented 1 year ago

@DavidBoike @soujay just a quick question for my understanding. What have we missed in https://github.com/Particular/setup-azureservicebus-action/pull/3?

danielmarbach commented 1 year ago

hmm... interesting. I'm pretty sure I ran an NPM update in the dev container. I wonder how I could make sure these things are properly done, done the next time. I wanted to be helpful, but it seems part was missed and also not picked up during the reviews. Would it make sense on the action repos to enable warning as error? Is that possible for the action runs?

DavidBoike commented 1 year ago

Part of it is that package-lock.json is an almost unreviewable file.

But when you update package.json it also updates package-lock.json in the "This is what you asked for" section (updated by this PR) vs. "this is what I provided to you based on your rules" (updated by #3).

So this change is saying "Before you wanted >= 1.9.1 and I gave you 1.10.0. Now you're saying you want >= 1.10.0 and obviously I'm still gonna give you 1.10.0."