search

ParticulateFlow / LIGGGHTS-PFM

This is an academic adaptation of the LIGGGHTS software package, released by the Department of Particulate Flow Modelling at Johannes Kepler University in Linz, Austria http://www.jku.at/pfm
GNU General Public License v2.0
48 stars 39 forks source link

#include "string.h" missing #1

Closed nasato closed 3 years ago

nasato commented 4 years ago

Hi old colleagues,

There might be a #include "string.h" missing in compute_com_molecule.cpp in the latest version (PFM 20.09). I could not compile without adding it.

All the best, Daniel

schrummy14 commented 4 years ago

Hello, How are you compiling the code? I doubled check with my install using make fedora and found no issues.

danielque commented 4 years ago

Thanks for the report. Probably, many compilers will make correct assumptions about the function prototype and then automatically link the library, but strictly speaking we should include string.h due to the usage of strcmp. Will be fixed in the next release.

nasato commented 4 years ago

Hello, How are you compiling the code? I doubled check with my install using make fedora and found no issues.

Hi,

I built it using cmake (v. 3.9.0) in CentOS 7.4

danielque commented 3 years ago

Fixed in d34544911fd9ec730455c3a35b12cf1370e6617d