Partonetrain / botaniacombat

BetterCombat weapons for Botania
MIT License
0 stars 1 forks source link

Shields not working with zenith #8

Open duarm opened 4 months ago

duarm commented 4 months ago

Thanks for making botania combat!

Botaniacombat shields do not fit into the reforging table from zenith, e.g. elementium shield below cant fit into the empty slot

image

Every weapon works

image

Netherite shield from guarding and every shield from Epic Knights mod works no problem, it might be worth investigating those in order to find out why botaniacombat shields do not work

Partonetrain commented 4 months ago

I believe compatibility with reforging is determined by Zenith material rarity, which is determined from Zenith's config. I could be wrong, as it's been a long time since I used its forge equivalent.

duarm commented 4 months ago

I can override the type from each botaniacombat shield inside zenith's Adventure.cfg to SHIELD, it does fit into the reforging table, but it doesnt work, the item appears affixed (the name is different), but no extra stat or sockets are given.

Partonetrain commented 1 month ago

Could possibly be related to #12 and how FabricShieldLib shields don't extend ShieldItem