PartyDAO / partybid

PartyBid contracts
MIT License
246 stars 63 forks source link

Add expiration time to PartyBid #68

Closed msfeldstein closed 2 years ago

msfeldstein commented 2 years ago

Adds an expiration timer to PartyBid so that a party that never meets reserve can get its funds back after a pre-determined time.

The party can choose to not call expire and continue trying to collect contributions and meet the reserve (at which time expire can no longer be called)

msfeldstein commented 2 years ago

I can move expiresAt into Party.sol, but should we merge the two repos so we don't have diverging base contracts?

msfeldstein commented 2 years ago

The shared contract did feel more complicated to me i wasn't sure what the purpose of it was (especially since partybuy lives elsewhere)