PartyBid Contracts - Githubissues

PartyDAO / partybid

PartyBid contracts

MIT License

246 stars 63 forks source link

PartyBid Contracts #8

Closed anna-carroll closed 3 years ago

anna-carroll commented 3 years ago

Original PR: https://github.com/PartyDAO/partybid/pull/1

Outstanding Comments:

[x] 30k gas limit https://github.com/PartyDAO/partybid/pull/1#discussion_r642247527
[x] remove totalContributed storage? https://github.com/PartyDAO/partybid/pull/1#discussion_r643324199
[x] require that Auction has not been finalized before bidding https://github.com/PartyDAO/partybid/pull/1#discussion_r643326833
[x] Recover NFT if auction is mistakenly marked as Lost (1) https://github.com/PartyDAO/partybid/pull/1#discussion_r643329535 (2) https://github.com/PartyDAO/partybid/pull/1#discussion_r650452428
[x] import interface, not contract https://github.com/PartyDAO/partybid/pull/1#discussion_r650451346
[x] change tokenURI check to ownerOf https://github.com/PartyDAO/partybid/pull/1#discussion_r650452028
[x] handle dust token amounts https://github.com/PartyDAO/partybid/pull/1#discussion_r650452709