Clean up sdlmutex.inc - Githubissues

PascalGameDevelopment / SDL2-for-Pascal

Unit files for building Free Pascal and Delphi applications using the SDL2 library

https://pascalgamedevelopment.github.io/SDL2-for-Pascal/

Mozilla Public License 2.0

103 stars 20 forks source link

Clean up sdlmutex.inc #123

Closed suve closed 1 year ago

suve commented 1 year ago

This patch fixes the definitions for PSDL_Mutex, PSDL_Sem and PSDL_Cond, adds a proper definition for SDL_MUTEX_MAXWAIT, and restores original SDL doc-comments for the mutex functions.

Free-Pascal-meets-SDL-Website commented 1 year ago

Thanks, looks good so far. Does this patch clean up to 2.0.14 or a later version?
The "WIP" tag should be removed from the version tag in sdl2.pas.

Best regards Matthias

suve commented 1 year ago

With this patch, sdlmutex.inc matches SDL_mutex.h as of SDL 2.26.3 - though to be fair, the API has not changed since SDL 2.0.0.

Free-Pascal-meets-SDL-Website commented 1 year ago

Thanks for the clean up!

I will merge this and update the version tag and the cheatsheet hint separately and directly to the master branch. This is quicker than pushing to this PR as these files are not included, yet.