search

PascalLesage / presamples

Package to write, load, manage and verify numerical arrays, called presamples.
BSD 3-Clause "New" or "Revised" License
14 stars 11 forks source link

Inconsistent arguments for RPA instantiation #31

Closed PascalLesage closed 6 years ago

PascalLesage commented 6 years ago

Places that assume list of (fp, shape): https://github.com/PascalLesage/brightway2-presamples/blob/seed/presamples/array.py#L20 https://github.com/PascalLesage/brightway2-presamples/blob/seed/presamples/array.py#L11

Places that assume list of fps only: https://github.com/PascalLesage/brightway2-presamples/blob/seed/presamples/loader.py#L176 https://github.com/PascalLesage/brightway2-presamples/blob/seed/presamples/package_interface.py#L113

TODO: confirm that list of (fp, shape) is what is required, and revert RPA instantiations to pass (fp, shape).

cmutel commented 6 years ago

Fixed in d9613f5.