search

PascalLesage / presamples

Package to write, load, manage and verify numerical arrays, called presamples.
BSD 3-Clause "New" or "Revised" License
14 stars 11 forks source link

Decoding presample json file fails #72

Open MaximeAgez opened 3 years ago

MaximeAgez commented 3 years ago

Hey Pascal,

Finally started working with presamples and I encountered this error:

image

It might be linked to my setup or it might be that there was an update of the json module that broke your code. I tried to simply read the json file outside of presamples and the decoding fails when introducing an "encoding" argument, but succeeds without the encoding argument.

Happy new year btw :)

tngTUDOR commented 3 years ago

@MaximeAgez , are you using python 3.9 ?

tngTUDOR commented 3 years ago

From the 3.9 documentation, the keyword argument "encoding":

So, I believe it can be safely removed.

tngTUDOR commented 2 years ago

Dear time-traveler,

If you come from the future, know that this issue has been solved as of version 0.2.8 of presamples. If you experience this, make sure you have the latest package version.

As of july 5th 2022, the package has not been updated neither on pypi nor on the channel of pascal. To have version 0.2.8, you must install from source:

for example (tested with pip version 22.0.4):

python -m pip install git+https://github.com/PascalLesage/presamples.git@master

@PascalLesage we can close the issue now, and it would be great if we could update the packages.