search

PascalSenn / keyboard-quickfix

Fully manage quick fix by keyboard
31 stars 6 forks source link

[BUG] not work on typescript and golang #1

Closed windwp closed 4 years ago

windwp commented 4 years ago

your extension not work. I think it have mistake https://github.com/PascalSenn/keyboard-quickfix/blob/f15df3754740c1c807151a56958890bbbb79d251/src/extension.ts#L40 i change it and it work.

  constructor(command: CodeActionCommand) {
    this.command = command;
    this.label = command.title;
    if (typeof command.command !== "string") {
      this.command = command.command as CodeActionCommand;
    }
  }

it will better if i can hide the label when i select command

aabccd021 commented 4 years ago

It also doen't work on flutter.

h7x4 commented 4 years ago

@windwp Could you submit a pull request?

PascalSenn commented 4 years ago

hi threre, sorry for the long response time, quite busy these days. I am happily gonna except the pull request. Do you mind removing the package-lock.json?

PascalSenn commented 4 years ago

Should be available: https://marketplace.visualstudio.com/items?itemName=pascalsenn.keyboard-quickfix

Thanks for the contribution ❤