search

PassFort / json-schema-to-flow-type

69 stars 17 forks source link

Update @babel/types #28

Closed sakai-akinobu closed 6 years ago

sakai-akinobu commented 6 years ago

Thank you for a nice module! I'm using it conveniently.

Babel v7.0.0-beta.48 it seems that the argument has been changed to objectTypeAnnotation of babel/types. https://github.com/babel/babel/pull/7947

27 Perhaps this issue is probably related to this change.

So I am glad that you will merge this fix.

sakai-akinobu commented 6 years ago

@wmonk Babel 7 was released, so I fixed it again. In order to solve #27, I want to merge this pull request. How about it?

apalm commented 6 years ago

Can this please be merged? 🙏 As @sakai-akinobu points out, the signature of objectTypeAnnotation has changed, and since the version of @babel/types used by this package isn't pinned, it's possible for versions >= 7.0.0-beta.48 to be installed, and causes #27.

screen shot 2018-09-12 at 14 25 54
arahansen commented 6 years ago

Just ran into this myself, would love to see this merged!

wmonk commented 6 years ago

Released in @1.0.0

sakai-akinobu commented 6 years ago

Thank you for taking the time!