Fix EventEmitter memory leak in TCPClient

PassTheMayo / minecraft-server-util

A Node.js library for Minecraft servers that can retrieve status, query, RCON, and send Votifier votes.

https://passthemayo.gitbook.io/minecraft-server-util/

MIT License

141 stars 24 forks source link

Fix EventEmitter memory leak in TCPClient #80

Closed DoctorMcKay closed 1 year ago

DoctorMcKay commented 1 year ago

Due to wrapping event handlers in arrow functions, data and close event handlers never get cleaned up when waiting for data on a TCP connection.

PassTheMayo commented 1 year ago

My apologies for a late reply, but unfortunately I will not be merging this pull request as the library will be deprecated in the near future. Information about this deprecation is posted on the README.