Passiday / OOP-Cards

Library for card games
4 stars 8 forks source link

Refactored code to fit (slightly modified) Airbnb style guide. #33

Open Phanty133 opened 4 years ago

Phanty133 commented 4 years ago

Mostly refactored the code, though added FIXME and TODO at some spots I either couldn't decipher or was too lazy to fix.

The modified style guide is in jsStyleGuide.md. Perhaps the style guide could be a section in the wiki? The differences between the original and this version are listed in the file. Although one key point I couldn't decide upon was the use of ++ and --. By default, they are disallowed in the guide (Section 13.6), but I have enabled them in the ESLint config.

Important note: /* eslint-disable lines-between-class-members */ should be written before defining static variables in classes, and /* eslint-enable lines-between-class-members */ should be placed after.

PS. I used tabs (Explained in the style guide).